Repository navigation
The Capabilities page in the desktop app (#152, B7) - #181
Open
Piggidragon wants to merge 10 commits into
Open
Piggidragon wants to merge 10 commits into
Piggidragon wants to merge 10 commits into
Conversation
The cap ls overview with each unit's effect, source and switch for one center, and the programs allowed as providers. The switches leave Permissions and the provider allow list leaves Settings > Advanced; the page opens with Ctrl+9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A dialog checks each field as the node and the center do while the owner types; the save runs cap add or cap edit with the schema on stdin, and what the node refuses stays in the dialog with its reason. Removing one asks first. Windows and a node run by hand say why they offer none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The dialog checks a capability's time limit against the node's own limits.max_timeout_secs, read with the page, not the default 3600. - A unit with no switch of its own shows its capability's (from the `centers` of `cap ls`), marked "like its capability". - A save's answer goes to the dialog that sent it; a refusal after the dialog closed is a toast, and a second save cannot run alongside. - Add and Save are always offered; a click shows the empty fields. - Tests for the stale `cap ls` answer, the raised limit, the inherited switch, the answers of saves and the empty save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dialog checks a time limit against the default once the node's limit is unset, its Arguments and Result boxes scroll, and an empty name or command stays an error after the first save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scrolling text box panned on a drag and selected nothing. The wheel and the cursor follow still scroll it. Also move the time-limit test above the doc comment of the dialog's save test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A pick and an unpairing of the shown center are tested now, and the "In use" pill says "Usable now", as the node only says the center may use the unit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also test the Programs row's Choose... button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A press on a line cut off at the bottom brings it into view, and how many lines fit depends on the platform's font; on Windows the old start scrolled the box by two pixels. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step B7 of #152, on main after B6 (#179). Part of #152.
The desktop app gets a Capabilities page (Ctrl+9). It shows what the node offers, switches it per center, lists the programs allowed as providers, and declares the capabilities of
node.tomlin a form. The switches leave Permissions and the provider allow list leaves Settings › Advanced (owner decision Q23).cap ls --json, per center):cap set … --center.cap provider allow/rm).[[capability]]entries ofnode.toml, with Add a capability…, Edit and Remove. Remove asks first.nerve_proto::schema::check, showing where and why a schema falls outside the subset, and the rest throughConfigCapability::validate. The time limit is checked against the node'slimits.max_timeout_secs.cap addorcap edit, with the schema on stdin. The node checks again, and what it refuses stays in the form with its reason. Enter saves.node.tomlcapabilities are offered there yet (Windows: the desktop app is the only way to the node #176). It hides Add and the program row, but keeps Edit, Remove and the removal of programs, so old entries can be cleaned up.capcommands.Tests
tests/caps.rs(unix) runs a real node in process:oneOfschema shows its pointer and reason and saves nothing;tests/app.rs:tests/fit.rs:keys.rs(Ctrl+9),view.rs(rows, notes, form checks,cap add/cap editarguments) andreference.rs(places).Review and checks
cargo fmt --check, clippy andcargo xwin clippy: clean.cargo test --workspace: 1703 passed, 0 failed.🤖 Generated with Claude Code