fix(filesystem): add comma separator in mountOptionsString - #3507
Open
Ray0907 wants to merge 1 commit into
Open
Conversation
mountOptionsString was concatenating options without commas, breaking readonly dete Signed-off-by: Ray Tien <ray.tien0907@gmail.com>
Member
|
Needs sign off. Also consider preallocating the string array. Not that its needed but why not. |
SuperQ
pushed a commit
that referenced
this pull request
Jun 9, 2026
* fix(filesystem): add comma separator in mountOptionsString mountOptionsString() was concatenating mount options without a separator, so isFilesystemReadOnly()'s strings.Split(opts, ",") could never find "ro" when it appeared alongside other options. As a result node_filesystem_readonly incorrectly reported 0 for any multi-option read-only mount, including ZFS filesystems mounted read-only and ext4 filesystems after a kernel emergency remount-ro triggered by errors=remount-ro. Also preallocate the slice with len(m) capacity, as suggested in review on #3507, to avoid repeated reallocations during append. Fixes: #3484 Fixes: #3576 Co-authored-by: Ray Tien <ray.tien0907@gmail.com> Signed-off-by: LeandroSaldivarmrf <leandro.saldivar@marfeel.com> * test(filesystem): add regression tests for mountOptionsString Signed-off-by: LeandroSaldivarmrf <leandro.saldivar@marfeel.com> --------- Signed-off-by: LeandroSaldivarmrf <leandro.saldivar@marfeel.com> Co-authored-by: Ray Tien <ray.tien0907@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mountOptionsString was concatenating options without commas, breaking
readonly dete
Fixes: #3484
Signed-off-by: Ray Tien ray.tien0907@gmail.com