fix(diskstats): only enforce mutual exclusivity for non-empty values - #3617
Merged
Conversation
prometheus#3603 introduced a subtle regression for existing configs where device-exclude was intentionally set to `=''` to clear the Linux default. This breaks configs that are valid (exclude is intentionally cleared). Update the mutual exclusivity check to only fail when the value is non-empty. Signed-off-by: winston <me@winstondurand.com>
R167
changed the title
SuperQ
approved these changes
Apr 8, 2026
Member
|
Thanks! |
Merged
SuperQ
added a commit
that referenced
this pull request
Jul 10, 2026
* [FEATURE] mountstats: Add NFS mountpoint info metric #3554 * [FEATURE] nvmesubsystem: Add new collector #3579 * [FEATURE] dmmultipath: Add new collector #3581 * [FEATURE] infiniband: Add device filtering option #3694 * [ENHANCEMENT] hwmon: disambiguate colliding chip labels #3646 * [ENHANCEMENT] cpufreq: Add support for cpuinfo_avg_freq #3712 * [ENHANCEMENT] filesystem: Support ext4 super block emergency_ro flag #3717 * [ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels #3720 * [BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values #3617 * [BUGFIX] thermal_zone: Handle EINVAL errors gracefully #3657 * [BUGFIX] filesystem: Add comma separator in mount options #3659 * [BUGFIX] diskstats: Fix rotational queue stats scrape regression #3686 * [BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names #3687 Signed-off-by: Ben Kochie <superq@gmail.com>
ajgon
pushed a commit
to deedee-ops/home-ops
that referenced
this pull request
Jul 11, 2026
….1 ➔ v1.12.0) (#297) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Warsaw) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTcuNCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ny40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvbWlub3IiXX0=--> Reviewed-on: https://git.ajgon.casa/deedee/mark13/pulls/297
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Jul 12, 2026
….1 ➔ v1.12.0) (#1526) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1526
dadezzz
pushed a commit
to dadezzz/infra_docker-compose
that referenced
this pull request
Jul 12, 2026
….12.0 (#511) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjI1Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
doonga
pushed a commit
to greyrock-labs/home-ops
that referenced
this pull request
Jul 13, 2026
….1 ➔ v1.12.0) (#47) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/New_York) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNjAuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI2MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.greyrock.io/greyrock-labs/home-ops/pulls/47
ajgon
pushed a commit
to deedee-ops/home-ops
that referenced
this pull request
Jul 13, 2026
….1 ➔ v1.12.0) (#297) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Warsaw) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTcuNCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ny40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvbWlub3IiXX0=--> Reviewed-on: https://git.ajgon.casa/deedee/mark13/pulls/297
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Jul 17, 2026
….12.1 ##### [\`v1.12.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.1) - \[BUGFIX] perf: Fix perf profiler flag handling [#3731](prometheus/node_exporter#3731) - \[BUGFIX] edac: Fix optional csrow ue\_count collection [#3734](prometheus/node_exporter#3734) --- ##### [\`v1.12.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#3687](prometheus/node_exporter#3687) --- ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
ajgon
pushed a commit
to deedee-ops/home-ops
that referenced
this pull request
Jul 20, 2026
….1 ➔ v1.12.0) (#297) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Warsaw) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTcuNCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ny40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvbWlub3IiXX0=--> Reviewed-on: https://git.ajgon.casa/deedee/mark13/pulls/297
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Jul 24, 2026
….12.1 ##### [\`v1.12.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.1) - \[BUGFIX] perf: Fix perf profiler flag handling [#3731](prometheus/node_exporter#3731) - \[BUGFIX] edac: Fix optional csrow ue\_count collection [#3734](prometheus/node_exporter#3734) --- ##### [\`v1.12.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#3687](prometheus/node_exporter#3687) --- ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
ajgon
pushed a commit
to deedee-ops/home-ops
that referenced
this pull request
Jul 28, 2026
….1 ➔ v1.12.0) (#297) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [quay.io/prometheus/node-exporter](https://github.com/prometheus/node_exporter) | minor | `v1.11.1` → `v1.12.0` | --- ### Release Notes <details> <summary>prometheus/node_exporter (quay.io/prometheus/node-exporter)</summary> ### [`v1.12.0`](https://github.com/prometheus/node_exporter/releases/tag/v1.12.0): 1.12.0 / 2026-07-10 [Compare Source](prometheus/node_exporter@v1.11.1...v1.12.0) - \[FEATURE] mountstats: Add NFS mountpoint info metric [#​3554](prometheus/node_exporter#3554) - \[FEATURE] nvmesubsystem: Add new collector [#​3579](prometheus/node_exporter#3579) - \[FEATURE] dmmultipath: Add new collector [#​3581](prometheus/node_exporter#3581) - \[FEATURE] infiniband: Add device filtering option [#​3694](prometheus/node_exporter#3694) - \[ENHANCEMENT] hwmon: disambiguate colliding chip labels [#​3646](prometheus/node_exporter#3646) - \[ENHANCEMENT] cpufreq: Add support for cpuinfo\_avg\_freq [#​3712](prometheus/node_exporter#3712) - \[ENHANCEMENT] filesystem: Support ext4 super block emergency\_ro flag [#​3717](prometheus/node_exporter#3717) - \[ENHANCEMENT] edac: Add per-channel error metrics with DIMM labels [#​3720](prometheus/node_exporter#3720) - \[BUGFIX] diskstats: Only enforce mutual exclusivity for non-empty values [#​3617](prometheus/node_exporter#3617) - \[BUGFIX] thermal\_zone: Handle EINVAL errors gracefully [#​3657](prometheus/node_exporter#3657) - \[BUGFIX] filesystem: Add comma separator in mount options [#​3659](prometheus/node_exporter#3659) - \[BUGFIX] diskstats: Fix rotational queue stats scrape regression [#​3686](prometheus/node_exporter#3686) - \[BUGFIX] filesystem: Prevent panic on mount points with non-UTF-8 names [#​3687](prometheus/node_exporter#3687) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Warsaw) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTcuNCIsInVwZGF0ZWRJblZlciI6IjQzLjI1Ny40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvbWlub3IiXX0=--> Reviewed-on: https://git.ajgon.casa/deedee/mark13/pulls/297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3603 introduced a subtle regression for existing configs where device-exclude was intentionally set to
=''to clear the Linux default. This breaks configs that are valid (exclude is intentionally cleared). Update the mutual exclusivity check to only fail when the value is non-empty.Repro
On
master, this fails with a mutual exclusivity error despite the exclude being intentionally empty. With this fix, it succeeds as expected.