build(deps): bump prometheus/procfs to v0.21.1 - #3715
Merged
Conversation
Update procfs to v0.21.1, along with transitive dependency bumps for golang.org/x/sys and golang.org/x/sync. This version changes the NVMe namespace directory regex from nvme\d+c\d+n to nvme\d+n. Rename the test fixture from nvme0c0n0 to nvme0n1 and update e2e expected output to match. Mdraid.Disks changed from uint64 to *uint64 (nil when unavailable, e.g. container/imsm/ddf arrays). Guard the dereference in mdadm_linux.go to prevent a nil pointer panic. Fixes: prometheus#3691 Signed-off-by: Shirly Radco <sradco@redhat.com> Co-authored-by: AI Assistant <noreply@cursor.com>
This was referenced Jul 6, 2026
Contributor
Author
|
@SuperQ Hi, I splitted this to a separate PR |
jan--f
approved these changes
Jul 6, 2026
Member
|
There's typically no need to split this kind of thing into a separate PR. But this case seems fine. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
prometheus/procfsto v0.21.1, along with transitivedependency bumps for
golang.org/x/sysandgolang.org/x/sync.Breaking changes handled
NVMe namespace regex: The namespace directory pattern changed
from
nvme\d+c\d+ntonvme\d+n. Updated the test fixture(
nvme0c0n0→nvme0n1) and e2e expected output (nsid="0"→nsid="1") to match.Mdraid.Diskstype change: Changed fromuint64to*uint64(nil when unavailable, e.g. container/imsm/ddf arrays). Added a
nil guard in
mdadm_linux.goto prevent a nil pointer panic.Fixes: #3691
Test plan
TestMdadmStatspassesmake test-e2e)Made with Cursor