Repository navigation
v3.8.0 Produces Java Code that does not compile #6286
Description
What version of protobuf and what language are you using?
Version: v3.8.0
Language: Java
What operating system (Linux, Windows, ...) and version?
macOS 10.14.5
What runtime / compiler are you using (e.g., python version or gcc version)
I'm using the compiler published as an artifact in a Maven repo.
What did you do?
v3.7.1 works fine. When I update to v3.8.0, I see the following issue.
Using the following gradle script snippet:
protobuf {
protoc {
artifact = 'com.google.protobuf:protoc:3.8.0'
}
//noinspection GroovyAssignabilityCheck
plugins {
grpc {
artifact = "io.grpc:protoc-gen-grpc-java:1.21.0"
}
}
generateProtoTasks {
ofSourceSet("main")*.plugins {
grpc {}
}
}
generatedFilesBaseDir = "$projectDir/src-generated"
}
Run the generateProto task.
What did you expect to see
The generated code should compile.
What did you see instead?
The generated classes that the plugin and protoc generate do not compile. The UnusedPrivateParameter class (without a package) is missing. Here's an snippet from some of the generated source:
@java.lang.Override
@SuppressWarnings({"unused"})
protected java.lang.Object newInstance(
UnusedPrivateParameter unused) {
return new MyType();
}Compile Error:
error: cannot find symbol
UnusedPrivateParameter unused) {
^
symbol: class UnusedPrivateParameter
location: class MyType
Activity
[-]3.8.0 Produces Java Code that does not compile[/-][+]v3.8.0 Produces Java Code that does not compile[/+]prashant4nov commentedon Jun 27, 2019
@pluttrell were you able to fix the issue? I am also having same issue.
hilbertglm commentedon Jun 27, 2019
I had the same problem, and adding the dependency as suggested resolved the issue for me.
prashant4nov commentedon Jun 27, 2019
@hilbertglm thanks for the reply. It worked now for me too.
pluttrell commentedon Jun 29, 2019
Yes, that did resolve my issue. Sorry for the delay.
deepakchandh commentedon Oct 29, 2019
Thanks
Thanks it did resolve the issue