Skip to content

createArchitectThread records engine defaults; an explicit harness/model flag would not be recorded #257

Description

@pseudoseed

Split from the #253 3-way review. Latent, not live.

#227 item 3 records (harness, model) on the architect row so a later attach pins the pair
the thread was created with. The value comes from ThreadEngine.defaults, read in
workspace-add-architect.ts just before createArchitectThread.

That is correct only because afx workspace add-architect has no --harness / --model
flags
. createArchitectThread accepts harnessName and model and passes them into
create, where they take precedence over the engine's defaults. The day a flag reaches that
call, the row will record the DEFAULT while the thread runs on the OVERRIDE — the same silent
divergence item 3 exists to close, arriving from the other direction.

Fix when the flags arrive: record what was passed, falling back to engine.defaults only
when nothing was. builders already works this way — upsertBuilder stores the pair the
spawn was given.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/towerTower, afx, terminals, messaging

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions