Skip to content

Migrate to spago v1#316

Draft
pete-murphy wants to merge 1 commit into
purescript:masterfrom
pete-murphy:migrate-to-spago-v1
Draft

Migrate to spago v1#316
pete-murphy wants to merge 1 commit into
purescript:masterfrom
pete-murphy:migrate-to-spago-v1

Conversation

@pete-murphy

Copy link
Copy Markdown
Contributor

Description of the change

Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@pete-murphy pete-murphy force-pushed the migrate-to-spago-v1 branch 2 times, most recently from 830af09 to 46dbaec Compare June 6, 2026 08:25
@pete-murphy pete-murphy force-pushed the migrate-to-spago-v1 branch from 46dbaec to 7f9b9a5 Compare June 6, 2026 13:11
Comment thread README.md
# Set up the PureScript environment for the server
cd staging
spago build
npm run build

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should leave this line unchanged

Comment thread client/src/Try/Config.js
@@ -0,0 +1,16 @@
const tag = "master";
const config = __DEVELOPMENT__

@pete-murphy pete-murphy Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__DEVELOPMENT__ gets replaced (rewritten to either true or false) by esbuild with --define:__DEVELOPMENT__=.. flag in package.json. This is another alternative to the choices discussed in #315

  1. Add a step to each script that copies the correct Try.Config.purs into src before bundling (and add src/Try.Config.purs to .gitignore).
  2. Separate packages for -dev and -prod (each containing only Try.Config module in src) with shared dependency on what's currently in the top-level package.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__DEVELOPMENT__ gets replaced

Maybe I should note this in the JS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant