Skip to content

fix: fix qt main window composition - #686

Merged
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
tlambert03:fix-main
Feb 2, 2025
Merged

fix: fix qt main window composition#686
tlambert03 merged 1 commit into
pyapp-kit:mainfrom
tlambert03:fix-main

Conversation

@tlambert03

Copy link
Copy Markdown
Member

fixes #685 by making _qwidget point to the actual MainWindow object (rather than the central widget) in the Qt MainWindow implementation

@codecov

codecov Bot commented Jan 5, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (bf9f663) to head (94b1a0e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/magicgui/backends/_qtpy/widgets.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   88.85%   88.86%   +0.01%     
==========================================
  Files          39       39              
  Lines        4756     4761       +5     
==========================================
+ Hits         4226     4231       +5     
  Misses        530      530              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
tlambert03 merged commit af861f4 into pyapp-kit:main Feb 2, 2025
@tlambert03
tlambert03 deleted the fix-main branch February 2, 2025 18:25
@tlambert03 tlambert03 added the bug Something isn't working label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MainWindow and Container exhibit assymetric behavior on .close()

1 participant