feat: expose canvas integration and camera APIs - #285
Conversation
|
The matrix found and helped fix two portability regressions in Two teardown-only jobs remain red and need a maintainer rerun (GitHub does not allow the fork author to rerun upstream jobs):
Neither reports an assertion failure in the integration APIs. Locally the complete suite is 190 passed / 14 skipped, including the new empty-scene regression test. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 85.20% 85.39% +0.19%
==========================================
Files 53 53
Lines 7192 7279 +87
==========================================
+ Hits 6128 6216 +88
+ Misses 1064 1063 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
thank you for this @kephale! I'm glad to see you're still playing around with ndv. I apologize for the delayed response. I'm buried under a backlog of things to respond to after my move. I can say up front that exposing camera APIs is a known high priority... and it touches stuff that @gselzer has been doing it abstracting away the heart of ndv into scenex... so i know there will be some overlap with #276 i apologize that i likely won't be able to give concrete feedback on this very soon. maybe @gselzer, who has been looking at these things more recently, might have thoughts on how to get you what you need (or perhaps even just merge this idea as is) without waiting for the whole refactor to land |
|
yay, hey @tlambert03! no worries on my side, this is a slower push from me so I can wait on @gselzer and adapt my implementation accordingly. my intention is just to get progressive loading support into the world. that said, i did find ndv to be one of the snappiest viewers with this implementation so it might become my main testing vehicle while investigating the chunk sampling/prioritization strategies. |
Human Kyle: I got here while building a viewer-agnostic progressive-loading module. This keeps the integration surface renderer-neutral and does not add a dependency on Lodstone.
Summary
ArrayViewer.canvasintegration surface and application-thread dispatch hookValidation
Teardown resolution
The earlier post-test failures were fixed rather than waived: