docs(upstream-review): track T3 watch items where the review workflow reads them - #173
Merged
Conversation
6 tasks
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
… reads them Issue #114 carried an upstream-watch table instructing a recheck "during Prime Agent upgrades and T3 upstream reviews", but the review-t3-upstream skill only reads .agents/upstream-review.md, which had no reference to #114. The duty was unenforceable, and unmerged upstream work is invisible to a commit-range review by construction. Add an "Upstream watch list" section holding upstream work that never enters a review range, keyed WATCH-n with an Owner issue, and extend the skill to read and maintain it in phases 1, 2.5, 4, 5, and the handoff. T3 rows move out of
Independent review of both task-parity items found #8097 is superseded: Pylon shipped the same fix in #137 via the latest_plan_activity CTE, before the upstream draft opened, and with waiting-step retention the draft's settled-turn gate would regress it. Its migration id 42 is unusable here and collides on upstream's own trunk. #5760 is a real defect present in Pylon and is Pylon's to fix; there is no upstream patch. Record the v2 SDK todo.updated approach and the two fragments of #8097 still worth taking on their own merits.
Also note in WATCH-1 that Pylon's own OpenCode task-progress fix is open as #178, so the row stays listed only because upstream #5760 is still open.
rynfar
force-pushed
the
docs/upstream-watch-ledger-sync
branch
from
August 30, 2026 19:05
00ed1cb to
f0e015d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #114 carries an upstream-watch ledger that says to recheck its entries "during Prime Agent upgrades and T3 upstream reviews". The
review-t3-upstreamskill reads.agents/upstream-review.md, which had zero references to #114 in either direction. The duty was written in an issue body that no workflow opens, so it was never enforceable.There is a structural reason this could not have been caught by the existing process either: three of #114's watched items are unmerged upstream work. A review bounded by
<cursor>..t3code-upstream/maincan only see commits, and a pull request that never merges produces no commit. Phases 2 and 3 of the skill are blind to that class of work by construction.The gap has already bitten. Checking the five watched T3 items against upstream today:
#5760OpenCode todowrite → task sidebar#8097restore composer tasks after relaunch#6573authenticated cross-thread MCP tools#7966server-side scheduled tasks (issue)#7986server-side scheduled tasks (PR)Three changed state on 2026-08-28 — the same day as the last T3 upstream review — and #114 still described them as live upstream signals. Nothing was adopted wrongly, because none of the watched work ever merged, but nothing noticed either.
Fix
Give each fact one owner, and put the T3 facts where the workflow provably looks.
.agents/upstream-review.mdgains an## Upstream watch list: upstream work that never enters a review range, keyedWATCH-n, each with anOwnerissue, a current signal, a checkableRevisit when, and the response Pylon intends to evaluate.WATCH-2andWATCH-3are rewritten around the closures — the implementations Pylon declined to cherry-pick no longer exist, so both now watch for a replacement with a 2026-11-01 floor rather than describing a dead PR.## Deferred register. Register entries were candidates in a batch, carry an upstream SHA, and end in adopt or skip. Watch entries have no SHA and may never land; conflating them would break both lifecycles.review-t3-upstream/SKILL.mdnow reads and maintains the list: preflight checks it exists (phase 1), phase 2.5 re-evaluates it withgh pr view --json state,mergedAtand treats a closed-unmerged PR as a real signal, phase 4 reports state changes, phase 5 maintains it, and the handoff is incomplete without it.WATCH-ids instead of duplicating them. Updated in the same change; no table is mirrored in two places.Verification
vp fmt --checkpasses on both files. No code paths touched.Not included
docs/internals/prime-agent-daemon-parity.mdis called authoritative by #114, which asks that both be updated when a linked PR lands. It has no mention of the user/delegate/external wait distinction that PR #137 shipped. That is a content gap in a different ledger and belongs in its own PR.Claude Opus 5 in Pylon.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.