fix(relay): release stalled Apple push deliveries - #295
Merged
Conversation
Give HTTP sends and response-body reads ten seconds each. Keep the existing typed transport errors, delivery records, and queue policy. Abort stalled requests and let the next signed job run. JWT retrieval is outside these deadlines. Do not add retries for an uncertain response result. Created with GPT-6 Astra (preview) in Codex. (cherry picked from commit 088cc3f95599b7b933289d719fa1e9b0608cb4cd)
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stalled Apple push request could hold a relay delivery batch open indefinitely. Give HTTP sending and response-body reading ten seconds each, cancel stalled requests, and let subsequent signed jobs run.
Adopts approved B12, upstream #9734, 088cc3f95599b7b933289d719fa1e9b0608cb4cd. Keeps Pylon’s typed transport errors, delivery records, queue policy, bundle identities and notification topics. JWT retrieval remains outside the deadlines; uncertain results are not retried. Applies to iOS notifications and Live Activities for every provider.
Validation: all 50 focused APNs client/delivery tests pass, including both timeout phases for both request types, cancellation signals and queue continuation. Relay typecheck, targeted lint and diff checks pass. No push was sent to a real device. Relay deployment is separate from this source change; no mobile binary update is needed for this server behavior.
Model: GPT-6 Astra. Harness: Codex.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.