feat(desktop): native notifications for agent attention - #424
Draft
ALGORITHM-0 wants to merge 10 commits into
Draft
feat(desktop): native notifications for agent attention#424ALGORITHM-0 wants to merge 10 commits into
ALGORITHM-0 wants to merge 10 commits into
Conversation
Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
…ions Update the desktop settings fixture for the new preference fields. Implemented with GPT-6 Astra in Codex App.
…k-through Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
Implemented with GPT-6 Astra in Codex App.
Keep pending notification objects alive until handled and release them when the desktop scope closes. Add collection-based lifetime regression coverage. Implemented with GPT-6 Astra in Codex App.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylon desktop currently gives no system notification when an agent finishes or needs attention while the user is in another app. This adds native notifications for approval, input, completion, and failure, with per-device controls in General settings and a test button.
The renderer reconciles awareness transitions across all connected environments and threads. First observation primes silently, focused or disabled transitions are consumed without replay, and Electron main gates delivery on window focus. Clicking restores Pylon and opens the target thread. All five preferences default to ON, as approved by the maintainer.
Candidates carry
environmentIdandthreadIdrather than the shared mobiledeepLink, so navigation uses the existing web route. Native notification objects remain alive until handled so delayed clicks retain their callbacks; the manual pass caught this lifetime issue and a collection-based regression test now covers it. No server, relay, mobile, or provider behavior changes.Validation:
@t3tools/contracts,@t3tools/web, and@t3tools/desktoppassed.Draft pending the repository-required before/after images and short recording of notification arrival and click-through. A settings screenshot is captured locally, but the computer-use tooling could not capture/upload the required full-screen recording. The implementation plan and approved design scratch file are intentionally excluded from this branch.
Implemented with GPT-6 Astra in Codex App.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.