Skip to content

feat(review): make PR comments easier to scan and submit - #621

Merged
rynfar merged 8 commits into
pylonfrom
upstream/2026-09-18-pr-review
Sep 18, 2026
Merged

rynfar merged 8 commits into
pylonfrom
upstream/2026-09-18-pr-review

Conversation

@rynfar

@rynfar rynfar commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Pull request conversations become difficult to scan when long bot reports and finished review threads dominate the page. This adopts five related upstream improvements: compact narrow-panel controls, Command/Control+Enter comment submission, grouped and paged comments with long-body previews, author avatars in detail views, and reliable avatar failure fallback.

Independent Opus review caught two issues before landing: bot authors now consistently link to GitHub app profiles, and resolved/dismissed groups mount lazily and page ten comments at a time. Collapse scrolling now runs after the preview height is applied. Pylon branding, projected multi-PR authority, remote environment identity, provider adapters and mobile wire compatibility are preserved. No migration, release or installation.

Upstream credit (original authors and cherry-pick provenance preserved):

  • Bilal Bakr — f0a0ead946ca3f3f310460a91b7dabb0e3fe4834 (#11962), narrow controls.
  • oliver / flamboh — f45c6b4a755905485431872f4a4188de3ed05974 (#11994), comment shortcut.
  • maria — c12ba7581ac00ba2a623ad23283da5d03d34c2d8 (#12150), scannable comments and bot metadata.
  • Exotic / extoci — 962bf62921c0ecbc9320f9b071e16b1d41484aad (#12125), detail avatars.
  • Harshith Goka — df466c79810046d20c0f3ccc4e51709c5703814e (#11728), avatar fallback.

Validation:

  • Focused server/contract and web regressions, including modifier/IME/repeat/pending/draft shortcuts, avatar error and URL recovery, bot profile links, and 150 resolved comments with lazy paging and PR switching.
  • Scoped contracts, client-runtime, server, web and mobile typechecks; changed-file lint.
  • Independent Claude Opus 5 adversarial server and UI reviews; UI corrections re-reviewed. Final product re-review at 94578d91ec passed 121 focused tests across five files; the unchanged server/contract review passed 219 tests across four files. Before/after screenshots, narrow-panel proof, and interaction recording are attached. Final-head CI passed at 6bf51fa18f72a9b2848430fac6039fca4c443d75: Check, Test, all three server shards, Rust, Release Smoke, background platform, and Linux/Windows packaged desktop smoke.

Known limits: GitHub bot enrichment uses the existing bounded GraphQL activity fetch; on fallback or beyond its metadata window an unsuffixed bot can remain unmarked. Other providers retain their existing actor metadata. Shared web/Electron UI changed; native mobile UI unchanged. Comment submission verified with mocked commands, without posting test comments to real PRs.

Closes #617. Five sources are fully adopted; frozen upstream head and review cursor stay unchanged. Remaining inventory goes from 143 to 138 upon merge.

Implemented with Codex (GPT-6-Astra); independently reviewed through Pylon delegation with Claude Agent / Claude Opus 5 after Antigravity quota blocked that provider.

Bil0000 and others added 7 commits September 17, 2026 21:43
(cherry picked from commit f0a0ead946ca3f3f310460a91b7dabb0e3fe4834)
(cherry picked from commit f45c6b4a755905485431872f4a4188de3ed05974)
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
(cherry picked from commit c12ba7581ac00ba2a623ad23283da5d03d34c2d8)
(cherry picked from commit 962bf62921c0ecbc9320f9b071e16b1d41484aad)
(cherry picked from commit df466c79810046d20c0f3ccc4e51709c5703814e)
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pylon-marketing Ready Ready Preview Sep 18, 2026 3:47am UTC

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Sep 18, 2026
@rynfar

rynfar commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

Browser verification on product head 94578d9 (final head adds only the upstream decision record). Read-only real PR #616 in isolated Pylon state: before/after comment overview, before/after code controls, a 1100px viewport showing readable narrow controls, grouped bot reports with app-profile links, and a 23-second recording of expanding, scrolling and collapsing a long report. The comment remains in view after collapse. Submission, IME/pending safeguards, avatar failure/recovery and 150 resolved-comment paging are covered by focused tests; no test comments were posted to the inspected PR.

Attachments in that order:
before-summary
after-summary
before-code
after-code
after-narrow
after-bots

comment-interaction.mp4

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.9 KiB 14.0 KiB +86 B (+0.6%) 15.1 KiB
Codex Thread snapshot wire 7.2 KiB 7.2 KiB +4 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.7 KiB 6.8 KiB +82 B (+1.2%) 7.8 KiB
Codex Live turn WebSocket decoded 58.0 KiB 58.0 KiB +88 B (+0.1%) 66.4 KiB
Codex Live turn messages 8 10 +2 (+25.0%) 21
Claude Total thread wire 14.0 KiB 14.0 KiB −13 B (−0.1%) 15.1 KiB
Claude Thread snapshot wire 7.2 KiB 7.2 KiB −3 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.7 KiB 6.7 KiB −10 B (−0.1%) 7.8 KiB
Claude Live turn WebSocket decoded 58.9 KiB 58.9 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 9 9 0 (0.0%) 21

Baseline: 3a0d8e4 · PR result: 6bf51fa · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 115.6 KiB
  • Claude decoded thread snapshot: 116.3 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit a85762e into pylon Sep 18, 2026
20 checks passed
@rynfar
rynfar deleted the upstream/2026-09-18-pr-review branch September 18, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream integration cycle: PR comments, controls and avatars

6 participants