feat: adding enable by henryiii · Pull Request #2048 · pypa/cibuildwheel

henryiii · 2024-10-19T04:49:36Z

Close #2045. Adds enable, deprecates the old way of specifying these (remove in 3.0).

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

mayeut · 2024-11-09T09:37:45Z

There are too many warnings issued for a single build. I will push some commits to rework deprecation notices.

Details

pybase64 % cibuildwheel --platform=linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead


     _ _       _ _   _       _           _
 ___|_| |_ _ _|_| |_| |_ _ _| |_ ___ ___| |
|  _| | . | | | | | . | | | |   | -_| -_| |
|___|_|___|___|_|_|___|_____|_|_|___|___|_|

cibuildwheel version 2.21.3

Build options:
  platform: linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

  allow_empty: False
  architectures: aarch64
  build_selector: 
    build_config: *
    skip_config: 
    requires_python: >=3.8
    enable: ['cpython-freethreading', 'pypy']
  output_dir: /Users/Matt/Dev/base64/pybase64/wheelhouse
  package_dir: /Users/Matt/Dev/base64/pybase64
  test_selector: 
    skip_config: *-win_arm64
  before_all: 
  before_build: 
  before_test: 
  build_frontend: None
  build_verbosity: 1
  config_settings: 
  container_engine: docker
  dependency_constraints: pinned
  environment: 
    *: 
    cp38-manylinux_aarch64, cp39-manylinux_aarch64, cp310-manylinux_aarch64, cp311-manylinux_aarch64, cp312-manylinux_aarch64, cp313-manylinux_aarch64, cp313t-manylinux_aarch64, pp38-manylinux_aarch64, pp39-manylinux_aarch64, pp310-manylinux_aarch64: 
      AUDITWHEEL_PLAT="manylinux2014_${AUDITWHEEL_ARCH}"
  manylinux_images: 
    x86_64: quay.io/pypa/manylinux_2_28_x86_64:2024.11.03-3
    i686: quay.io/pypa/manylinux2014_i686:2024.11.03-3
    pypy_x86_64: quay.io/pypa/manylinux_2_28_x86_64:2024.11.03-3
    aarch64: quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3
    ppc64le: quay.io/pypa/manylinux_2_28_ppc64le:2024.11.03-3
    s390x: quay.io/pypa/manylinux_2_28_s390x:2024.11.03-3
    pypy_aarch64: quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3
    pypy_i686: quay.io/pypa/manylinux2014_i686:2024.11.03-3
  musllinux_images: 
    x86_64: quay.io/pypa/musllinux_1_2_x86_64:2024.11.03-3
    i686: quay.io/pypa/musllinux_1_2_i686:2024.11.03-3
    aarch64: quay.io/pypa/musllinux_1_2_aarch64:2024.11.03-3
    ppc64le: quay.io/pypa/musllinux_1_2_ppc64le:2024.11.03-3
    s390x: quay.io/pypa/musllinux_1_2_s390x:2024.11.03-3
    armv7l: quay.io/pypa/musllinux_1_2_armv7l:2024.11.03-3
  repair_command: auditwheel repair -w {dest_dir} {wheel}
  test_command: pytest {project}/tests
  test_extras: 
  test_groups: 
  test_requires: 
    -r
    requirements-test.txt

Cache folder: /Users/Matt/Library/Caches/cibuildwheel

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Here we go!

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Starting container image quay.io/pypa/manylinux_2_28_aarch64:2024.11.03-3...

info: This container will host the build for cp38-manylinux_aarch64, cp39-manylinux_aarch64, cp310-manylinux_aarch64, cp311-manylinux_aarch64, cp312-manylinux_aarch64, cp313-manylinux_aarch64, cp313t-manylinux_aarch64, pp38-manylinux_aarch64, pp39-manylinux_aarch64, pp310-manylinux_aarch64...
+ docker version -f '{{json .}}'
Cannot connect to the Docker daemon at unix:///Users/Matt/.docker/run/docker.sock. Is the docker daemon running?

                                                              ✕ 0.12s
Error: Build failed because docker is too old or is not working properly.

mayeut · 2024-11-09T10:05:43Z

The warnings now show as:

pybase64 % cibuildwheel --platform=linux
Warning: free-threaded-support and prerelease-pythons should be specified by enable instead

Warning: PyPy builds will be disabled by default in version 3. Enabling PyPy builds should be specified by enable


     _ _       _ _   _       _           _
 ___|_| |_ _ _|_| |_| |_ _ _| |_ ___ ___| |
|  _| | . | | | | | . | | | |   | -_| -_| |
|___|_|___|___|_|_|___|_____|_|_|___|___|_|

cibuildwheel version 2.21.3

Build options:
....

…handled via explicit enable option. See pypa/cibuildwheel#2048

This is now handled via explicit enable option. See pypa/cibuildwheel#2048

henryiii commented Oct 19, 2024

View reviewed changes

Comment thread cibuildwheel/util.py Outdated

henryiii force-pushed the henryiii/feat/enable branch from d7329df to a70d4b3 Compare October 21, 2024 14:55

henryiii mentioned this pull request Oct 21, 2024

chore: stricter mypy #2053

Merged

henryiii force-pushed the henryiii/feat/enable branch from a70d4b3 to 8a54c9f Compare October 22, 2024 14:17

henryiii mentioned this pull request Nov 1, 2024

Release plans: 2.22 and 3.0 #2047

Closed

henryiii force-pushed the henryiii/feat/enable branch 2 times, most recently from cc80f2c to bbc0a19 Compare November 1, 2024 15:11

henryiii changed the title ~~WIP: start adding enable~~ feat: adding enable Nov 1, 2024

mayeut reviewed Nov 2, 2024

View reviewed changes

Comment thread cibuildwheel/options.py Outdated

henryiii force-pushed the henryiii/feat/enable branch from bbc0a19 to e2c5f24 Compare November 6, 2024 04:46

feat: adding enable

17df90f

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

henryiii force-pushed the henryiii/feat/enable branch from e2c5f24 to 17df90f Compare November 6, 2024 04:55

henryiii marked this pull request as ready for review November 6, 2024 05:25

refactor: use recommended term

fecdfac

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

mayeut added 2 commits November 9, 2024 10:43

fix: use cached_property for Options properties

0d26dc7

fix: warn on PyPy default

e427357

mayeut approved these changes Nov 11, 2024

View reviewed changes

henryiii merged commit 393e035 into pypa:main Nov 14, 2024

henryiii deleted the henryiii/feat/enable branch November 14, 2024 16:39

mayeut mentioned this pull request Nov 23, 2024

fix: cibuildwheel.schema.json #2093

Merged

dsbferris added a commit to dsbferris/spacy-alignments that referenced this pull request Jun 17, 2026

Deprecated free-threaded-support option in cibuildwheel. This is now …

2730cf5

…handled via explicit enable option. See pypa/cibuildwheel#2048

dsbferris added a commit to dsbferris/spacy-alignments that referenced this pull request Jun 17, 2026

Deprecated free-threaded-support option in cibuildwheel.

e65d401

This is now handled via explicit enable option. See pypa/cibuildwheel#2048

Navigation Menu

Repository navigation

feat: adding enable - #2048

feat: adding enable#2048
henryiii merged 4 commits into
pypa:mainfrom
henryiii:henryiii/feat/enable

henryiii commented Oct 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mayeut commented Nov 9, 2024

Uh oh!

mayeut commented Nov 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

henryiii commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mayeut commented Nov 9, 2024

Uh oh!

mayeut commented Nov 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

henryiii commented Oct 19, 2024 •

edited

Loading