Repository navigation
Resolve symlinks when checking backend-path containment - #242
Open
blouirts123 wants to merge 1 commit into
Open
blouirts123 wants to merge 1 commit into
blouirts123 wants to merge 1 commit into
Conversation
blouirts123
marked this pull request as draft
October 16, 2026 04:52
blouirts123
marked this pull request as ready for review
October 16, 2026 05:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
norm_and_check()accepts a relative backend directory whose symlink target is outside the source tree. This lets a project unintentionally depend on an external directory despite the helper's in-tree path check.Resolve both the source root and requested backend path for containment checks, while continuing to return the original normalized absolute path. This preserves valid in-tree links and source roots accessed through a link. It follows PEP 517's recommended frontend check for self-contained source trees: https://peps.python.org/pep-0517/#in-tree-build-backends .
Validation:
WinError 1314failure intest_path_pollution_symlinked_in_process. That failure also reproduces on the unchanged base.-Wpassed.git diff --checkpassed. Linux/macOS tests were not run locally.