Invoke pyroma through the command line#9669
Closed
radarhere wants to merge 1 commit into
Closed
Conversation
Contributor
|
Using subprocess isn't an option for iOS, as Python doesn't support the subprocess module (the same will be true for Android or Emacripten). If this is the approach that is adopted, the test will need to be skipped - However, I feel a better approach would be to do this outside the scope of pytest, and run it as a separate post-build check of wheels, rather than try to analyze a wheel while running code in (or adjacent to) that wheel. |
Member
Author
|
I attempted to run it outside of pytest, but it still triggered a subprocess error on iOS. |
Member
|
Do we need to run it on all platforms as part of the test suite? Can we instead put it in tox as part of the For example: #9670. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9668
The maintainer of pyroma has declared that it is a command line tool, not a library. This PR updates test_pyroma.py to use
subprocessto call it, rather than using the import.You will notice that I have also removed our code handling
rcversions (I don't think we've used this since 3.1.0.rc1) and relaxed the pyroma version requirement (now that the changes from #9116 are gone).