Skip to content

chore: enable pep 563/585 - #148

Merged
abn merged 3 commits into
python-poetry:masterfrom
branchv:pep-563
May 30, 2022
Merged

abn merged 3 commits into
python-poetry:masterfrom
branchv:pep-563

Conversation

@branchv

@branchv branchv commented May 30, 2022

Copy link
Copy Markdown
Member

This updates our type annotations to take advantage of PEP 563 and PEP 585.
All the heavy lifting was done by pyupgrade.

Relates to python-poetry/poetry#5088

@branchv
branchv requested a review from a team May 30, 2022 15:41
Comment thread .pre-commit-config.yaml
hooks:
- id: isort
args: [--add-import, from __future__ import annotations]
exclude: ^tests/ui/(helpers|test_exception_trace).py$

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding these for now since the test checks exact line numbers and thus causes a lot of churn when those change:

at {}:19 in test_render_better_error_message
15│ def test_render_better_error_message():
16│ io = BufferedIO()

@abn
abn merged commit 2c0b0b4 into python-poetry:master May 30, 2022
@branchv
branchv deleted the pep-563 branch May 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants