Repository navigation
chore: enable pep 563/585 - #148
Merged
Merged
Conversation
branchv
commented
May 30, 2022
| hooks: | ||
| - id: isort | ||
| args: [--add-import, from __future__ import annotations] | ||
| exclude: ^tests/ui/(helpers|test_exception_trace).py$ |
Member
Author
There was a problem hiding this comment.
Excluding these for now since the test checks exact line numbers and thus causes a lot of churn when those change:
cleo/tests/ui/test_exception_trace.py
Lines 31 to 33 in 28eb7ba
abn
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our type annotations to take advantage of PEP 563 and PEP 585.
All the heavy lifting was done by
pyupgrade.Relates to python-poetry/poetry#5088