Repository navigation
Modernize code base - #131
Conversation
b3186bd to
26509f9
Compare
26509f9 to
aab7513
Compare
aab7513 to
c45f29d
Compare
|
@finswimmer Let me know if you still see something that needs changing. |
|
I am gonna go ahead and merge this. The import issue has already been fixed on Poetry's side (python-poetry/poetry#3696) and the fix will be available in the next |
| @@ -1,6 +0,0 @@ | |||
| from poetry.core.pyproject.exceptions import PyProjectException | |||
There was a problem hiding this comment.
This removal breaks https://github.com/python-poetry/poetry/blob/6eaa2984d9fb51a837c4ab11643f4dd9d7828d4d/poetry/console/commands/config.py#L14 (current master).
| from .patterns import TILDE_PEP440_CONSTRAINT | ||
| from .patterns import X_CONSTRAINT | ||
| from .version import Version | ||
| from .version_constraint import VersionConstraint |
There was a problem hiding this comment.
This removal of the VersionConstraint import breaks https://github.com/python-poetry/poetry/blob/6eaa2984d9fb51a837c4ab11643f4dd9d7828d4d/poetry/repositories/repository.py#L5 (current master).
|
@sdispater: Besides the type annotations and Python version housecleaning, multiple changes in this PR modify the public API of |
|
@nickray Thanks for sharing you concerns.
There is currently a work in progress branch (https://github.com/python-poetry/poetry/compare/modern-core) on Poetry's side to update the imports and code to account for these changes in |
* Update CI files for Python 3.6+ only * Modernize codebase * Reorganize imports to improve performance
This PR modernizes the code by doing the following: