Skip to content

Fix parsing of caret constraint with leading zero #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdispater merged 1 commit into from
Sep 15, 2021
+18 −2
Merged

Fix parsing of caret constraint with leading zero #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poetry/core/semver/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def stable(self) -> "Version":

def next_breaking(self) -> "Version":
if self.major == 0:
if self.minor != 0:
if self.minor is not None and self.minor != 0:
return self.next_minor()

if self.precision == 1:
Expand Down
2 changes: 1 addition & 1 deletion tests/semver/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def test_parse_constraint_tilde(input, constraint):
Version.from_parts(1, 0, 0), Version.from_parts(2, 0, 0), True
),
),
("^0", VersionRange(Version.from_parts(0), Version.from_parts(0, 1), True)),
("^0", VersionRange(Version.from_parts(0), Version.from_parts(1), True)),
(
"^0.0",
VersionRange(
Expand Down
16 changes: 16 additions & 0 deletions tests/semver/test_parse_constraint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,22 @@
include_min=True,
),
),
(
"^0",
VersionRange(
min=Version.from_parts(0),
max=Version.from_parts(1),
include_min=True,
),
),
(
"^0.0",
VersionRange(
min=Version.from_parts(0, 0),
max=Version.from_parts(0, 1),
include_min=True,
),
),
],
)
def test_parse_constraint(constraint, version):
Expand Down