Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions poetry/core/packages/dependency_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ def is_optional(self) -> bool:
def add_dependency(self, dependency: "DependencyTypes") -> None:
self._dependencies.append(dependency)

def remove_dependency(self, name: "str") -> None:
def remove_dependency(self, name: str) -> None:
Comment thread
neersighted marked this conversation as resolved.
Resolved
from poetry.core.utils.helpers import canonicalize_name

name = canonicalize_name(name)

dependencies = []
for dependency in dependencies:
for dependency in self.dependencies:
Comment thread
neersighted marked this conversation as resolved.
Resolved
if dependency.name == name:
continue

Expand Down
24 changes: 24 additions & 0 deletions tests/packages/test_dependency_group.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
from poetry.core.packages.dependency import Dependency
from poetry.core.packages.dependency_group import DependencyGroup


def test_dependency_group_remove_dependency():
group = DependencyGroup(name="linter")
group.add_dependency(Dependency(name="black", constraint="*"))
group.add_dependency(Dependency(name="isort", constraint="*"))
group.add_dependency(Dependency(name="flake8", constraint="*"))

assert {dependency.name for dependency in group.dependencies} == {
"black",
"isort",
"flake8",
}

group.remove_dependency("isort")
assert {dependency.name for dependency in group.dependencies} == {"black", "flake8"}

group.remove_dependency("black")
assert {dependency.name for dependency in group.dependencies} == {"flake8"}

group.remove_dependency("flake8")
assert {dependency.name for dependency in group.dependencies} == set()