Skip to content

Deprecate Python 3.6 - #263

Merged
finswimmer merged 18 commits into
python-poetry:masterfrom
tony:deprecate-python-3.6
Feb 3, 2022
Merged

finswimmer merged 18 commits into
python-poetry:masterfrom
tony:deprecate-python-3.6

Conversation

@tony

@tony tony commented Jan 16, 2022 •

Copy link
Copy Markdown
Contributor

Resolves: python-poetry/poetry#4997
See also: python-poetry/poetry#5055, python-poetry/install.python-poetry.org#11

As I'm getting acclimated with the code base, this may have some back and forth to it

  • Added tests for changed code.
  • Updated documentation for changed code.

Later?

@tony
tony marked this pull request as draft January 18, 2022 14:31
@tony
tony force-pushed the deprecate-python-3.6 branch from f239329 to da1f8ad Compare January 18, 2022 14:40
@tony
tony marked this pull request as ready for review January 22, 2022 17:13

@branchv branchv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tony, couple suggestions

Comment thread pyproject.toml Resolved
Comment thread pyproject.toml Resolved
Comment thread tests/testutils.py Resolved
Comment thread src/poetry/core/utils/_compat.py Resolved
Comment thread src/poetry/core/utils/_compat.py Resolved
@neersighted neersighted self-assigned this Jan 25, 2022
@tony
tony force-pushed the deprecate-python-3.6 branch from d73e3a3 to a3262b5 Compare January 25, 2022 15:19
danieleades
danieleades previously approved these changes Jan 25, 2022
danieleades
danieleades previously approved these changes Jan 28, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tony

tony commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

@neersighted can this have tests ran on them?

Is it possible to allow tests to always run for me?

@tony
tony requested a review from danieleades January 29, 2022 12:04
@tony

tony commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

in re:

@tony tony dismissed danieleades’s stale review via 4bb19c9 1 minute ago

@danieleades Just a rebase against master

@neersighted

Copy link
Copy Markdown
Member

@neersighted can this have tests ran on them?

Is it possible to allow tests to always run for me?

There is no manual whitelist. Having a merged PR will automatically run CI for you in the future.

@finswimmer
finswimmer merged commit 98793c8 into python-poetry:master Feb 3, 2022
@tony
tony deleted the deprecate-python-3.6 branch February 5, 2022 20:12
@finswimmer finswimmer mentioned this pull request Feb 9, 2022
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this pull request Mar 26, 2022
* Vendors: Bump min python 3.6 -> 3.7

* ci: Remove python 3.6

* ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7

* chore(flake8): Add min_python_version

* deps(pyproject): Bump minimum python 3.6 -> 3.7

* deps: Remove PEP 557 (dataclasses) backport for 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore(tox): remove python 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: Remove PY36

* CI(integration): Remove 3.6

* chore(testutils.py): Unused args

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify isort markers

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify pre-commit marker

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* chore: Cleanup unused condition, import

* chore: Remove PY37 checks (unused)

* chore: Fix codesmell

See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL

* chore: Remove FileNotFoundError

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
* Vendors: Bump min python 3.6 -> 3.7

* ci: Remove python 3.6

* ci[pre-commit]: Update pyupgrade arg 3.6 -> 3.7

* chore(flake8): Add min_python_version

* deps(pyproject): Bump minimum python 3.6 -> 3.7

* deps: Remove PEP 557 (dataclasses) backport for 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore(tox): remove python 3.6

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* chore: Remove PY36

* CI(integration): Remove 3.6

* chore(testutils.py): Unused args

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify isort markers

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* build(deps): Simplify pre-commit marker

Co-authored-by: Branch Vincent <branchevincent@gmail.com>

* chore: Cleanup unused condition, import

* chore: Remove PY37 checks (unused)

* chore: Fix codesmell

See also: https://sonarcloud.io/project/issues?id=poetry-core&open=AX5towEhmZqnEonFAx80&pullRequest=263&resolved=false&types=CODE_SMELL

* chore: Remove FileNotFoundError

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate Python 3.6

5 participants