Skip to content

Add: pycln as a pre-commit hook - #360

Merged
abn merged 1 commit into
python-poetry:masterfrom
hadialqattan:master
May 21, 2022
Merged

abn merged 1 commit into
python-poetry:masterfrom
hadialqattan:master

Conversation

@hadialqattan

Copy link
Copy Markdown
Contributor

Resolves: N/A

  • [N/A] Added tests for changed code.
  • [N/A] Updated documentation for changed code.

A continuation PR for Adding Pycln QA tool to the pre-commit config based on:

@hadialqattan sorry for forgetting about this! If you're up for it, https://github.com/python-poetry/poetry-core would definitely benefit from this as well. Originally posted by @branchvincent in python-poetry/poetry#5234 (comment)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@branchv branchv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks again!

the downstream test failure is of course unrelated, but unfortunately prevents me from merging this. I'll see if someone else can help us out

@abn
abn merged commit 8b96495 into python-poetry:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants