Repository navigation
Cache compiled JSON schema validators - #965
Merged
Merged
Conversation
Schema files are static, but each validation currently recompiles validators. Cache them by schema name to avoid repeated compilation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
Author
|
less than 20% but more than 10% comparing the previous CI run with the one for this pull request before: 85s, after 76s there is quite a lot of noise eg because of randomisation of test order, I was seeing more locally, it is what it is |
radoering
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit artificial - I do not expect this to make any real difference to users, a typical execution of poetry will not run this path often.
But: running the complete set of poetry unit test - where we load the same schema many many times - this saves something like 20% of wall time. Which is enough of an improvement to the developer experience that it seems worth having.