Repository navigation
add private attribute to fit the implementation of the mocked class - #93
Merged
radoering merged 1 commit intoAug 7, 2022
Merged
Conversation
The equivalent of the attribute Locker._contains_credential needs to be added to TestLocker to mock it properly.
|
Kudos, SonarCloud Quality Gate passed!
|
1 of 2 tasks
radoering
approved these changes
Aug 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The equivalent of the attribute
Locker._contains_credentialneeds to be added toTestLockerto mock it properly.This patch is needed to fix the tests error in PR python-poetry/poetry#3995 (which adds the
_contains_credentialattribute)