Repository navigation
presence of setup.py breaks entrypoint generation #2324
Description
- I am on the latest Poetry version.
- I have searched the issues of this repo and believe that this is not a duplicate.
- If an exception occurs when executing a command, I executed it again in debug mode (
-vvvoption).
- OS version and name: macOS 10.15.4
- Poetry version: 1.0.5
Issue
I had a dummy setup.py (based on this post):
#!/usr/bin/env python
import setuptools
if __name__ == "__main__":
setuptools.setup()When that file is present two things happen when doing poetry install:
- egg info is now created under
UNKNOWN.egg-info entry_points.txtis no longer generated
Interestingly enough entry_points.txt is still present in a generated wheel.
Steps to reproduce
poetry new testpoint
cd testpoint
printf '\n[tool.poetry.plugins.test]\nmain = "foo"' >> pyproject.toml
echo 'import setuptools; setuptools.setup()' > setup.py
poetry install
Activity
finswimmer commentedon Apr 19, 2020
Hello @wichert,
as the last step in
poetry installpoetry creates a temporarysetup.pyand usespipto install the package itself in editable mode (pipcan't do this at the moment with apyproject.toml). If there is already asetup.pypoetry will not overwrite this one, sopipwill use the one already present.Is there any reason why you've created the
setup.py? This is not necessary when usingpoetry. Just remove the file and everything should work fine.fin swimmer
wichert commentedon Apr 19, 2020
Hi fin,
I have to admit that with all the changes in
setup.py,setup.cfgandpyproject.tomlI am having a hard time figuring out what exactly goes where and why. I hadn't realised not having a setup.py was actually a viable approach here, and since this project was migrated to poetry it already had asetup.py. Perhaps it would be helpful if poetry could give a warning ifsetup.pyalready exists?louwers commentedon Aug 24, 2020
setup.pyis still needed for Cython extensions, for intergration with some versioning systems or for better support for namespace packages, e.g.abn commentedon Aug 25, 2020
@louwers can't this be done via poetry's
packagesconfiguration? Also note that poetry detects namespace packages without any issues.abn commentedon Aug 25, 2020
@wichert with
1.1.0poetry will not usesetuptoolsfor the editable installs. The presence of a setup file should not impact this anymore.See: #2360
github-actions commentedon Mar 3, 2024
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.