Poetry 1.1.2 does not export dependency url for nested git dependencies #3115

Activity

1. marns93

   added

   kind/bugSomething isn't working as expectedSomething isn't working as expected

   status/triageThis issue needs to be triagedThis issue needs to be triaged

   on Oct 7, 2020
2. marns93 commented on Oct 7, 2020

   

   marns93

   on Oct 7, 2020

   Author

   More actions

   @abn Could you please have a look?
3. abn

   added 4 commits that reference this issue on Oct 7, 2020

   locker: ensure dependency constraint is correct

   ...

   This issue will close once commit 15bfdbe is merged into the 'main' branch.

   15bfdbe

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 01da8ad is merged into the 'main' branch.

   01da8ad

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 689a949 is merged into the 'main' branch.

   689a949

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 2ca46d0 is merged into the 'main' branch.

   2ca46d0
4. rugleb commented on Oct 12, 2020

   

   rugleb

   on Oct 12, 2020

   Last edited by rugleb

   More actions

   I have a similar problem in version 1.1.2.

   In ad_strategies project I have next dependencies:

   [tool.poetry.dependencies]
   python = "^3.8"
   ad_ml = { git = "ssh://git@git.ucb.local:7999/ad/ad_ml.git", tag = "v0.6.0" }
   

   In ad_scores package I need ad_strategies package:

   [tool.poetry.dependencies]
   python = "^3.8"
   ad_strategies = { git = "ssh://git@git.ucb.local:7999/ad/ad_strategies.git", tag = "v0.3.0" }
   

   Result of poetry export -f requirements.txt --without-hashes command in ad_scores package is:

   ad-ml==0.6.0
   ad_strategies @ git+ssh://git@git.ucb.local:7999/ad/ad_strategies.git@v0.3.0
   

   and it wrong, I expect:

   ad-ml @ git+ssh://git@git.ucb.local:7999/ad/ad_ml.git@v0.6.0
   ad_strategies @ git+ssh://git@git.ucb.local:7999/ad/ad_strategies.git@v0.3.0
   

   Sorry for my English
5. abn commented on Oct 12, 2020

   

   abn

   on Oct 12, 2020

   Member

   More actions

   Can you please try the fix at #3119.

   Using pipx

   pipx install --suffix=@3119 'poetry @ git+https://github.com/python-poetry/poetry.git@refs/pull/3119/head'

   Using a container (podman | docker)

   podman run --rm -i --entrypoint bash python:3.8 <<EOF
   set -e
   python -m pip install -q git+https://github.com/python-poetry/poetry.git@refs/pull/3119/head
   python -m poetry new foobar
   pushd foobar
   sed -i /pytest/d pyproject.toml
   python -m poetry add 'git+ssh://git@github.com/moneymeets/sampleproject.git#83068b995c2f94b0d51333b932b1a939084e9ef7'
   python -m poetry export -f requirements.txt --without-hashes
   EOF

   Note: The container example will require authorised pubkeys or the dependency references to be updated to anonymous ssh urls or https urls.
6. johnpaulett commented on Oct 12, 2020

   

   johnpaulett

   on Oct 12, 2020

   More actions

   I'm having a similar issue with nested relative path local dependencies on poetry 1.1.2:

   ...
   mypkg.common==0.0.1
   mypkg.sdk @ ../../libs/sdk
   mypkg.logger==0.0.1
   ...
   

   It appears that poetry@3119 fixes it:

   ...
   mypkg.common @ /tmp/mypkg/libs/py/common; python_version >= "3.8" and python_version < "3.9"
   mypkg.sdk @ /tmp/mypkg/libs/py/sdk; python_version >= "3.8" and python_version < "3.9"
   mypkg.logger @ /tmp/mypkg/libs/py/logger; python_version >= "3.8" and python_version < "3.9"
   ...
   

   Not a problem, but interestingly, many lines now include the python_version restrictions (all of my internal dependencies and many third party libraries).
7. abn

   added 3 commits that reference this issue on Oct 13, 2020

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit c09db50 is merged into the 'main' branch.

   c09db50

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 9854506 is merged into the 'main' branch.

   9854506

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 04967db is merged into the 'main' branch.

   04967db
8. zyv commented on Oct 14, 2020

   

   zyv

   on Oct 14, 2020

   Contributor

   More actions

   Closing this, since the problem is finally resolved in #3119.
9. abn

   added a commit that references this issue on Oct 14, 2020

   locker: reuse locked metadata for nested deps

   ...

   This issue will close once commit 2974d40 is merged into the 'main' branch.

   2974d40
10. finswimmer

    closed this as completedin 02307baon Oct 14, 2020
11. abn

    removed

    status/triageThis issue needs to be triagedThis issue needs to be triaged

    on Mar 3, 2022
12. thatch

    added a commit that references this issue on Feb 26, 2024

    locker: reuse locked metadata for nested deps

    ...

    This issue will close once commit 02307ba is merged into the 'master' branch.

    02307ba
13. github-actions commented on Mar 2, 2024

    

    github-actionsBot

    on Mar 2, 2024 – with GitHub Actions

    More actions

    This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
14. github-actions

    locked as resolved and limited conversation to collaborators on Mar 2, 2024