Skip to content

VCS ignored files with poetry build #4800

Closed

Description

@anth2o
  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Hello there,
I spent some time figuring out that poetry build implicitly ignored files in the .gitignore. I had to look in the source code here to make sure my issue was coming from this behavior. I think it might be good to explicit this either in the documentation or in the CLI help of poetry build
Thanks

Activity

  1. added
    area/docsDocumentation issues/improvements
    status/triageThis issue needs to be triaged
    on Nov 19, 2021
  2. finswimmer commented on Nov 26, 2021

    @finswimmer
    Member

    Hello @anth2o,

    it's mentioned here. But you are right, it would be good to make it clear in a more prominent way.

    fin swimmer

  3. heavelock commented on Nov 29, 2021

    @heavelock

    I just bumped into the same issue. Is this behavior something that Poetry definitely wants to keep? Would a PR adding a flag that would turn off including .gitignore be accepted?

    I just discovered that this behavior can be overcome by explicit include = [] in pyproject.toml. It would be great if this would be documented.

  4. Secrus commented on May 16, 2022

    @Secrus
    Member

    I think adding a short note about explicit include overcoming VCS ignore file wouldn't hurt. PRs are welcome.

  5. added a commit that references this issue on May 23, 2022
  6. github-actions commented on Mar 2, 2024

    @github-actions

    This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  7. locked as resolved and limited conversation to collaborators on Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/docsDocumentation issues/improvements

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions