Errors not shown following clean-up of big stacks #5846

Activity

1. dimbleby

   added

   kind/bugSomething isn't working as expectedSomething isn't working as expected

   status/triageThis issue needs to be triagedThis issue needs to be triaged

   on Jun 14, 2022
2. dimbleby commented on Jun 14, 2022

   

   dimbleby

   on Jun 14, 2022

   ContributorAuthor

   More actions

   @Bobronium I guess it must be python-poetry/cleo#132 that did this
3. Bobronium commented on Jun 14, 2022

   

   Bobronium

   on Jun 14, 2022

   Last edited by Bobronium

   More actions

   I see your point and I agree.

   Can you post the output of poetry add requests -v as well as -vv and -vvv?

   From the description, my guess is that you're hitting plain assert usage without a message, which is an issue in itself and I'd say it should be replaced with something more descriptive.

   To address your point: I think it really belongs to cleo. As well as my following thoughts:

   It might be worth checking if exception has any args (e.g. message) and if not, fallback to printing traceback).

   The more fine and "right" solution would be introducing expected exception class/set and hide traceback only for that exceptions.
4. dimbleby commented on Jun 14, 2022

   

   dimbleby

   on Jun 14, 2022

   ContributorAuthor

   More actions

   $ poetry add requests -v
   
   Using virtualenv: /home/dch/.virtualenvs/foo
   Using version ^2.28.0 for requests
   
   Updating dependencies
   Resolving dependencies... (0.0s)
   
     AssertionError
   
   
   
     at ~/poetry/src/poetry/mixology/incompatibility.py:114 in __str__
         110│         )
         111│
         112│     def __str__(self) -> str:
         113│         if isinstance(self._cause, DependencyCause):
       → 114│             assert len(self._terms) == 2
         115│
         116│             depender = self._terms[0]
         117│             dependee = self._terms[1]
         118│             assert depender.is_positive()
   

   More verbose versions are more verbose, but I think would just clog this up - indeed we have hit an assertion with no message
5. mkniewallner commented on Jun 14, 2022

   

   mkniewallner

   on Jun 14, 2022

   Member

   More actions

   It might be worth checking if exception has any args (e.g. message) and if not, fallback to printing traceback).

   This seems like a good short term solution indeed, pending, as you suggest, some changes to properly raise errors with actionable error messages for the end user (as even if we do bring back tracebacks for errors without message, the user would still have to guess what the error is about).
6. Secrus

   closed this as completedin cleo#166on Jul 12, 2022
7. mkniewallner

   removed

   status/triageThis issue needs to be triagedThis issue needs to be triaged

   on Jul 31, 2022
8. github-actions commented on Mar 1, 2024

   

   github-actionsBot

   on Mar 1, 2024 – with GitHub Actions

   More actions

   This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
9. github-actions

   locked as resolved and limited conversation to collaborators on Mar 1, 2024