Repository navigation
Add key to allow fetching submodules for git repos #611
Description
- I have searched the issues of this repo and believe that this is not a duplicate.
Issue
Currently, git dependencies do not fetch submodules. This makes dependencies like mypy unusable when installing it from git. I don't think fetching submodules should be the default behavior, but it would be nice if git dependencies had the option to fetch them. For instance:
[tool.poetry.dependencies]
# Submodules would not be fetched for sqlalchemy-stubs
sqlalchemy-stubs = {rev = "8b45fc4345778e3f08e8a3b53ff71aaaa775e632", git = "https://github.com/dropbox/sqlalchemy-stubs.git"}
[tool.poetry.dev-dependencies]
# Submodules would be fetched for mypy because of submodules = true
mypy = {rev = "47c25263694bae2a577c15d70d2988db2e8e8584", git = "https://github.com/python/mypy.git", submodules = true}Reacted by Sergey Alexandrov, Christoph Minixhofer, David Barroso, drunkwcodes, oakkitten, Rafael, John Children, nirvana-msu, Hugo-C, Oussama Tchita and 1 more
Activity
MiniXC commentedon Jun 11, 2019
I currently have the same problem with pocketsphinx, which uses submodules as well. Is there any workaround for now?
dbarrosop commentedon Jun 26, 2019
is there any progress on this? I am also having this problem :(
stale commentedon Nov 13, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
stale commentedon Nov 20, 2019
Closing this issue automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one.
kradalby commentedon Dec 18, 2019
+1 to this
sdispater commentedon Dec 20, 2019
Maybe Poetry should just always pull submodules for Git dependencies. This would avoid introducing yet another option which would complicate things in the codebase and pulling submodules should not have any side effect that I can think of.
Pull in Git submodule
Pull in Git submodule
github-actions commentedon Mar 3, 2024
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.