Repository navigation
perf: avoid urljoin for absolute urls - #10896
Merged
Merged
Conversation
This makes locking 15 % faster in some cases.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
file['url']is reused only once, you could avoid reassigningfile_urland instead compute a localresolved_urlto keep the logic clearer between the original value and the normalized URL.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `file['url']` is reused only once, you could avoid reassigning `file_url` and instead compute a local `resolved_url` to keep the logic clearer between the original value and the normalized URL.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Secrus
approved these changes
May 16, 2026
2 tasks done
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes locking 15 % faster in some cases.
Pull Request Check List