Skip to content

Used pyupgrade to remove compatibility code - #3861

Merged
finswimmer merged 5 commits into
python-poetry:masterfrom
ThatXliner:master
Apr 2, 2021
Merged

finswimmer merged 5 commits into
python-poetry:masterfrom
ThatXliner:master

Conversation

@ThatXliner

@ThatXliner ThatXliner commented Mar 30, 2021 •

Copy link
Copy Markdown
Contributor

Relates-to: #3860

Pull Request Check List

Resolves: #issue-number-here ( may not remove all compatibility code)

  • [N/A ] Added tests for changed code.
  • [N/A ] Updated documentation for changed code.

@ThatXliner

Copy link
Copy Markdown
Contributor Author

Sorry for the messy commits!

@finswimmer
finswimmer requested a review from a team March 30, 2021 19:27
@finswimmer finswimmer added the kind/refactor Pulls that refactor, or clean-up code label Mar 30, 2021

@finswimmer finswimmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ThatXliner 🥇

Some minor suggestion where the conversion to f-string haven't worked well enough.

TIL: yield from 👍

Comment thread poetry/publishing/uploader.py Resolved
Comment thread poetry/publishing/uploader.py Resolved
Comment thread poetry/publishing/uploader.py Resolved
Comment thread poetry/puzzle/solver.py Resolved
@ThatXliner

Copy link
Copy Markdown
Contributor Author

@ThatXliner
ThatXliner requested a review from finswimmer March 31, 2021 19:31

@finswimmer finswimmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. Looks good to me 👍

@finswimmer
finswimmer merged commit b753aaf into python-poetry:master Apr 2, 2021
@github-actions

github-actions Bot commented Mar 1, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/refactor Pulls that refactor, or clean-up code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants