Skip to content

feat: pyupgrade via pre-commit - #4758

Merged
neersighted merged 2 commits into
masterfrom
neersighted/pyupgrade
Nov 17, 2021
Merged

neersighted merged 2 commits into
masterfrom
neersighted/pyupgrade

Conversation

@neersighted

Copy link
Copy Markdown
Member

Run pyupgrade against the whole codebase, as well as add a pyupgrade pre-commit hook to prevent obsolete syntax/imports in the future.

@neersighted
neersighted force-pushed the neersighted/pyupgrade branch from 40b0d0e to 96c84bb Compare November 15, 2021 00:25
Comment thread .pre-commit-config.yaml
hooks:
- id: pyupgrade
args: [--py36-plus]
exclude: '^(install|get)-poetry.py$'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are excluded as get-poetry.py is in maintenance mode and install-poetry.py is vendored from a different repo.

neersighted and others added 2 commits November 16, 2021 18:51
Implements the reviews from #3987 and #3988. Special thanks to the
committers and reviewers there.

Co-authored-by: Harry Peach <harrypeach1999@gmail.com>
Co-authored-by: Kamyar Ghasemlou <kamyar@kamy.me>
Co-authored-by: Leonardo Freua <leonardo.batista.freua@gmail.com>

@finswimmer finswimmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@neersighted
neersighted merged commit fd3f338 into master Nov 17, 2021
@neersighted
neersighted deleted the neersighted/pyupgrade branch November 17, 2021 22:36
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants