Repository navigation
Use flake8-eradicate - #4806
Merged
Merged
Use flake8-eradicate#4806
Conversation
Member
|
It seems like it could be useful to aid code review and/or help prevent new contributors from having more things to fix on a PR. That being said, I haven't seen a lot of commented out code during review. Thoughts, @finswimmer and @abn? |
Member
neersighted
approved these changes
Nov 28, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates-to: #4776
Very low hanging fruit, but perhaps too little benefit or maybe just an investment in the future.
There seems to be no commented out code in poetry (or
eradicatecan't find it).eradicateonly finds 5 false positives in this comment:When extending the whitelist, you have to ask yourself how specific or general you want the regex to be.