Skip to content

Rework completions section in docs - #5879

Merged
neersighted merged 5 commits into
python-poetry:masterfrom
Secrus:rework-completions
Jun 21, 2022
Merged

Rework completions section in docs#5879
neersighted merged 5 commits into
python-poetry:masterfrom
Secrus:rework-completions

Conversation

@Secrus

@Secrus Secrus commented Jun 19, 2022

Copy link
Copy Markdown
Member

Pull Request Check List

Resolves: #2295

  • Updated documentation for changed code.

@Secrus Secrus added the area/docs Documentation issues/improvements label Jun 19, 2022
@github-actions

github-actions Bot commented Jun 19, 2022 •
edited
Loading

Copy link
Copy Markdown

Deploy preview for website ready!

✅ Preview
https://website-4rf49m3gw-python-poetry.vercel.app

Built with commit bed7157.
This pull request is being automatically deployed with vercel-action

@Secrus
Secrus requested a review from a team June 19, 2022 14:06
@Secrus Secrus mentioned this pull request Jun 20, 2022
Closed
neersighted
neersighted requested changes Jun 20, 2022
View reviewed changes

@neersighted neersighted left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see partial authorship attribution for the author of #4002 if that's appropriate (haven't compared in detail yet).

Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Comment thread docs/_index.md Resolved
Secrus and others added 3 commits June 20, 2022 18:35
@Secrus @neersighted
Apply suggestions from code review
d25d8b9 
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@Secrus @neersighted
Apply suggestions from code review
e7d5d88 
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
@Secrus
Apply suggested changes
bed7157
@Secrus

Secrus commented Jun 20, 2022

Copy link
Copy Markdown
Member Author

I'd like to see partial authorship attribution for the author of #4002 if that's appropriate (haven't compared in detail yet).

@neersighted in this case, there is no code that was taken from that PR, nor was I inspired by it. I can add attribution, but I don't think it's appropriate in this case.

@Secrus
Secrus requested a review from neersighted June 20, 2022 16:40
@neersighted
neersighted merged commit 2571a42 into python-poetry:master Jun 21, 2022
@Secrus
Secrus deleted the rework-completions branch June 21, 2022 13:24
@mkniewallner mkniewallner mentioned this pull request Jul 12, 2022
Merged
@github-actions

github-actions Bot commented Feb 29, 2024

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@neersighted neersighted neersighted approved these changes

Assignees

No one assigned

Labels

area/docs Documentation issues/improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installing bash completion requires root privileges

2 participants

@Secrus @neersighted