Skip to content

Missing setup.py on releases? #305

Closed

Description

@luizribeiro

While packaging tomlkit 0.11.8 for NixOS we noticed that starting on 0.11.7 the released packages no longer include setup.py (see full discussion on NixOS/nixpkgs#245440).

While setup.py is no longer actually necessary, this creates a circular dependency to build tomlkit moving forward - as tomlkit itself would require poetry to be able to build tomlkit, while poetry itself depends on tomlkit to be built.

Was the removal of setup.py intended?

Activity

  1. luizribeiro commented on Jul 26, 2023

    @luizribeiro
    Author

    Ah, it seems like this happened because of python-poetry/poetry-core#318

    I guess we could explicitly set tool.poetry.build.generate-setup-file here so we can still build tomlkit without poetry?

    I'm going to put up a PR for that.

  2. frostming commented on Jul 27, 2023

    @frostming
    Contributor

    this creates a circular dependency to build tomlkit moving forward - as tomlkit itself would require poetry to be able to build tomlkit, while poetry itself depends on tomlkit to be built.

    This is not true, tomlkit only requires poetry-core to build and the latter has zero-dependency, it doesn't vendor tomlkit either. You may need to investigate carefully to find out the real cause. Or otherwise you may have misconfigured your build process.

  3. luizribeiro commented on Jul 27, 2023

    @luizribeiro
    Author

    Thank you for the clarification, @frostming!

    It looks like nixpkgs has the wrong dependencies for poetry-core indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions