Repository navigation
Fix AttributeError on an out-of-order table under an indented header - #663
Conversation
Parsing " [a.b.c.d]\n[a.b.c]" raised "'OutOfOrderTableProxy' object has no attribute 'trivia'". The intermediate tables created for an indented header carry its indent, and Table.append copies that indent onto the item it just stored. When that key is now split out of order, the lookup returns an OutOfOrderTableProxy, which has no trivia. Skip the indent copy for the proxy; its parts keep their own indentation. Issue python-poetry#263 was the three-level form of this, which only stopped failing because the outermost super table has no indent.
Wkhanex
left a comment
Wkhanex
left a comment
There was a problem hiding this comment.
AI-assisted validation at d0484992a8bd on Python 3.12.14: I expanded the indentation case to spaces, a tab, and mixed space/tab indentation at depths 4–6, for both a table and an array of tables. Each input also had an intervening unrelated table and a value added through the reopened parent. All 18 combinations parsed and preserved the original text before mutation, and their serialized data after mutation matched tomllib. The 23 focused out-of-order tests passed.
The mutation check matters here because skipping proxy trivia must leave its component tables usable after the initial parse, as well as avoid the AttributeError. I did not find a discrepancy in those cases.
|
Friendly ping @frostming: this still merges cleanly on current master (no conflicts after 0.15.2) and CI is green. Happy to rebase or adjust anything if you'd prefer a different approach. |
|
hey @frostming, bumping this one since #664 went in. same area of the code, still merges clean on master. happy to rebase or change the approach if you'd rather fix it another way |
|
✅ Human Attestation: @frostming attested this PR at commit
Later pushes to this PR stay attested. Attestation page |
Fixes #661.
Table.appendcopies the parent's indent onto the item it just stored, but when that key is split out of order the lookup returns anOutOfOrderTableProxy, which has no trivia. The fix skips the proxy, since its parts already keep their own indentation. #263 was the same crash one level up and only stopped happening because the outermost super table has no indent.