gh-128770: fix ResourceWarning in test_pyrepl#128906
Merged
pablogsal merged 1 commit intoJan 22, 2025
Merged
Conversation
graingert
force-pushed
the
fix-resource-warning-in-test-pyrepl
branch
from
4536f9c to
ca5eb67
Compare
graingert
changed the title
RuntimeWarning in test_socket
graingert
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
graingert
added
needs backport to 3.12
hugovk
approved these changes
Jan 16, 2025
pablogsal
approved these changes
Jan 22, 2025
|
Thanks @graingert for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 22, 2025
(cherry picked from commit 24c84d8) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
Sorry, @graingert and @pablogsal, I could not cleanly backport this to |
|
GH-129179 is a backport of this pull request to the 3.13 branch. |
Member
|
The new REPL is only on 3.13 so the 3.12 backport is not needed :) |
Contributor
Author
|
Oh whoops |
pablogsal
pushed a commit
that referenced
this pull request
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.