gh-147805: handles large addresses in arm64 relocations#147941
Draft
kumaraditya303 wants to merge 2 commits into
Draft
gh-147805: handles large addresses in arm64 relocations#147941kumaraditya303 wants to merge 2 commits into
kumaraditya303 wants to merge 2 commits into
Conversation
Fidget-Spinner
approved these changes
Apr 3, 2026
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks, could you please fix the lint errors?
Fidget-Spinner
requested changes
Apr 3, 2026
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
On second thought, after understanding the code better, I have some concerns. Will leave this to Diego to review.
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be put in the comfy chair! |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.