gh-146495: Improve SyntaxError message for && and || operators#150906
Open
Aniketsy wants to merge 3 commits into
Open
gh-146495: Improve SyntaxError message for && and || operators#150906Aniketsy wants to merge 3 commits into
SyntaxError message for && and || operators#150906Aniketsy wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "invalid syntax. Maybe you meant 'and' or '&' instead of '&&'"); | ||
| return; | ||
| } | ||
| if (last_token->type == VBAR && p->tokens[p->fill - 2]->type == VBAR) { |
sobolevn
reviewed
Jun 4, 2026
| def test_double_pipe(self): | ||
| self._check_error( | ||
| "a || b", | ||
| "Maybe you meant 'or' or '|' instead of '||'", |
Member
There was a problem hiding this comment.
Can you please also assert the error location, it should be the second | or & char.
Contributor
Author
There was a problem hiding this comment.
thanks for the review, i've updated with error location, please let me know if we need any further improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #146495
As there was not any pr for this for long time, so i thought to give a try for this as @skirpichev have shared the patch towards fix. Hoping it does not create much pain to review for members. Thank you !
&&and||#146495