Skip to content

bpo-32604: Disable failing tests#20777

Merged
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race
Jun 21, 2020
Merged

bpo-32604: Disable failing tests#20777
nanjekyejoannah merged 1 commit into
python:masterfrom
nanjekyejoannah:fix_race

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

@vstinner

vstinner commented Jun 17, 2020

Copy link
Copy Markdown
Member

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".

@nanjekyejoannah nanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters module bpo-32604: Disable failing tests Jun 17, 2020
@nanjekyejoannah nanjekyejoannah merged commit 6f79838 into python:master Jun 21, 2020
@nanjekyejoannah

Copy link
Copy Markdown
Contributor Author

Merging until we get a fix @ericsnowcurrently

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants