Skip to content

[3.10] bpo-43988: Add test.support.check_disallow_instantiation() (GH-25757)#26885

Merged
miss-islington merged 5 commits into
python:3.10from
erlend-aasland:backport-4f72526-3.10
Jun 23, 2021
Merged

[3.10] bpo-43988: Add test.support.check_disallow_instantiation() (GH-25757)#26885
miss-islington merged 5 commits into
python:3.10from
erlend-aasland:backport-4f72526-3.10

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

(cherry picked from commit 4f72526, fbff538, and 8cec740)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue43988

Automerge-Triggered-By: GH:vstinner

…thonGH-25757).

(cherry picked from commit 4f72526)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland

erlend-aasland commented Jun 23, 2021

Copy link
Copy Markdown
Contributor Author

I'll backport GH-26392, GH-26394, and GH-26412 after this has been merged.

EDIT: the two former PR's have been included in this backport PR, as they belong to the same bpo issue.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please fix the doc.

Comment thread Doc/library/test.rst Outdated

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@miss-islington

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

test_ttk_guionly failed on Ubuntu in Azure Pipelines.

2021-06-23T22:15:57.5133290Z ======================================================================
2021-06-23T22:15:57.5133791Z FAIL: test_configure_to (tkinter.test.test_ttk.test_widgets.SpinboxTest)
2021-06-23T22:15:57.5134904Z ----------------------------------------------------------------------
2021-06-23T22:15:57.5135381Z Traceback (most recent call last):
2021-06-23T22:15:57.5135890Z   File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1175, in test_configure_to
2021-06-23T22:15:57.5136405Z     self._click_increment_arrow()  # 5
2021-06-23T22:15:57.5136909Z   File "/home/vsts/work/1/s/Lib/tkinter/test/test_ttk/test_widgets.py", line 1135, in _click_increment_arrow
2021-06-23T22:15:57.5137627Z     self.assertRegex(self.spin.identify(x, y), r'.*uparrow\Z')
2021-06-23T22:15:57.5138321Z AssertionError: Regex didn't match: '.*uparrow\\Z' not found in ''

@miss-islington

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0a3452e into python:3.10 Jun 23, 2021
@erlend-aasland erlend-aasland deleted the backport-4f72526-3.10 branch June 24, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants