Re-land "[xplat] Update pthreadpool to google/pthreadpool github revision a56dcd7" (with patches) - #20654
Re-land "[xplat] Update pthreadpool to google/pthreadpool github revision a56dcd7" (with patches)#20654GregoryComer wants to merge 1 commit into
Conversation
…sion a56dcd7" (with patches) Summary: Attempt pytorch#2 to land the pthreadpool dependency update - D104906625 was reverted in D109744957 due to performance regressions. I've patched back in per-thread wakeup for futex/condvar paths, as the new dispatch regresses when running with our (existing) subset of threads patch. See D107950404 for full performance testing on the new vs old stack. Differential Revision: D109876168
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20654
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0d06e58 with merge base d54a0c0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109876168. |
This PR needs a
|
|
Hi @GregoryComer! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Summary:
Attempt #2 to land the pthreadpool dependency update - D104906625 was reverted in D109744957 due to performance regressions.
I've patched back in per-thread wakeup for futex/condvar paths, as the new dispatch regresses when running with our (existing) subset of threads patch. See D107950404 for full performance testing on the new vs old stack.
Differential Revision: D109876168