Fix QNN online-prepare graph handle retrieval - #21860
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21860
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Awaiting Approval, 1 New FailureAs of commit 6b1af15 with merge base bd2e855 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
|
@pytorchbot label "release notes: qualcomm" |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
CI is currently blocked on fork-workflow approval rather than a test failure. Dr. CI reports no failed jobs, both CLA checks are satisfied, and the QNN workflow has not started yet. Could a maintainer please approve the pending workflows, especially Test QNN Backend, Test QNN Windows MSVC build, and Lint, so the change can receive actual CI validation? Thanks. |
Retrieve graphs composed from DLC for ONLINE_PREPARE and exercise the runtime path with a dedicated QNN backend test flow.
15196d5 to
6b1af15
Compare
|
Hi @sylvesterkaczmarek, thanks for the PR and sorry for the delay. Running CI now |
chenweng-quic
left a comment
There was a problem hiding this comment.
withdraw approval since I cannot reproduce issue mentioned in #21804 (comment)
chenweng-quic
left a comment
There was a problem hiding this comment.
withdraw approval
Fixes #21804.
QnnContext::Configure()registers DLC graphs into the QNN context forONLINE_PREPAREbeforeQnnGraph::Configure()runs. The graph configuration path then skipped both graph creation and graph retrieval, leavinggraph_handlenull and storing it inhandle_.This change retrieves already-registered DLC graphs with
qnn_graph_retrieve, matching the deserialization path, appliesAfterRetrieveGraph, and defensively rejects a null graph handle before bookkeeping.Validation: adds a dedicated
qnn_online_preparebackend test flow and wires it into QNN pull-request and scheduled CI so this runtime path is exercised alongside the existing QNN flow. The branch is rebased on currentmainand kept to one commit.cc @cbilgin @psiddh