Skip to content

Upstream candidate: resource monitor binaries ship without the executable bit #1

Description

@q1

Observed while packaging q1code: the published npm package t3@0.0.38 contains dist/resource-monitor/<platform>/t3-resource-monitor with mode 0644 (pnpm pack normalizes modes). After npm install the file is not executable, so ResourceMonitorBinary.resolve fails with ResourceMonitorBinaryNotExecutable on launcher-installed servers.

Reproduce:

curl -fsSL "$(npm view t3@latest dist.tarball)" -o t3.tgz
tar -tvzf t3.tgz | grep resource-monitor

Fix options for an up/ branch cut from main (no fork references in the diff or PR text):

  1. In apps/server/src/resourceTelemetry/ResourceMonitorBinary.ts, chmod 0755 once when the bundled binary exists but lacks 0o111, before failing.
  2. Or post-process modes in apps/server/scripts/cli.ts publish.

q1code works around it at install time (scripts/fork/install.sh) and in the cliproxy resolver.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    upstream-candidateGeneric fix that should go to pingdotgg/t3code via an up/ branch

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions