Skip to content

feat: add intfloat/multilingual-e5-small support - #694

Open
guapimm wants to merge 1 commit into
qdrant:mainfrom
guapimm:feat/add-multilingual-e5-small
Open

feat: add intfloat/multilingual-e5-small support#694
guapimm wants to merge 1 commit into
qdrant:mainfrom
guapimm:feat/add-multilingual-e5-small

Conversation

@guapimm

@guapimm guapimm commented Aug 29, 2026

Copy link
Copy Markdown

Summary

Fixes #123.

Add native support for intfloat/multilingual-e5-small to FastEmbed's pooled text embedding models.

Changes

  • Register intfloat/multilingual-e5-small
  • Use the model's ONNX export from Hugging Face
  • Add model metadata for dimension, license, size, and supported languages
  • Add canonical embedding values for regression testing

The model is also usable through TextEmbedding.add_custom_model; native registration makes it discoverable through the standard supported-model list.

Tests

  • Model downloaded and loaded successfully
  • Embedding shape verified as (384,)
  • Canonical embedding values verified within the existing tolerance
  • python -m compileall -q fastembed tests/test_text_onnx_embeddings.py
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fa2e33ec-c417-4666-a2ac-ab9f79fb0e73

📥 Commits

Reviewing files that changed from the base of the PR and between c48247f and 57d6cf8.

📒 Files selected for processing (2)
  • fastembed/text/pooled_embedding.py
  • tests/test_text_onnx_embeddings.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Adds intfloat/multilingual-e5-small to the supported pooled models with its dimensions, license, size, source, and ONNX model path. Adds the model's canonical embedding vector to the text ONNX embedding test fixtures.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 57d6c

This change makes one additional embedding model discoverable and validates its metadata, output shape, and canonical values through existing paths. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: joein

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding support for intfloat/multilingual-e5-small.
Description check ✅ Passed The description directly explains the model registration, metadata, ONNX export, regression test coverage, and validation steps.
Linked Issues check ✅ Passed The changes satisfy issue #123 by adding native support for intfloat/multilingual-e5-small, including model registration and regression test data.
Out of Scope Changes check ✅ Passed All changed files support the linked objective. The model registration and canonical embedding fixture are in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intfloat/multilingual-e5-small request

1 participant