Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"; now["GET","POST"], and the request method is uppercased before comparison.badRequestimport. Without it, a request that failed validation threw a ReferenceError and returned 500 instead of 400.User.userNametousernameso it matches the API routes and tests.paginatestub. Page and size are clamped to positive integers."types": ["bun-types"]so tsc can findbun:testandprocess.bun-typeswas already a devDependency.Verification
bun testgives 22 pass / 0 fail.tsc --noEmitexits 0. No test files modified, no dependencies added.Assumptions
usernamefield andPOST /usersbeing public.paginatedoesn't guard againstsize = Infinity, and turns an invalidsizeinto 1 instead of a default. The tests don't cover this, so I left it as is.