fix(accessibility): add aria-label to announce ORCID profile in author metadata HTML/Reveal.js#14602
Merged
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
mcanouil
changed the title
cderv
approved these changes
Jun 29, 2026
cderv
left a comment
cderv
left a comment
Member
There was a problem hiding this comment.
Can you add a quick test ? Just for template regression.
Collaborator
Author
too late it seems |
cderv
added a commit
that referenced
this pull request
Jun 29, 2026
…14602) Extends the ORCID accessibility test suite to cover HTML and Reveal.js (#14602) alongside the existing ipynb tests (#14632). One shared fixture (title-block-orcid.qmd) renders to all three formats, replacing the format-specific title-block-orcid-ipynb.qmd. The affiliation fixture stays separate as it covers a distinct ipynb template path.
cderv
added a commit
that referenced
this pull request
Jun 29, 2026
Merge into existing #14602 entry since both PRs fix the same gap (ORCID link has no accessible name for screen readers) across different output formats.
cderv
added a commit
that referenced
this pull request
Jun 29, 2026
…14632) The ipynb title-block had the same ORCID accessibility gap as HTML/Reveal.js (#14602): the link carrying the ORCID icon had no accessible name, causing screen readers to fall back to announcing raw base64 image data. The attribute-based fix from #14602 (aria-label / alt="") cannot be used here: ipynb.lua deliberately strips all image attributes (imgEl.attr = pandoc.Attr()) to prevent pandoc from emitting raw <img> HTML, which breaks notebook attachment handling in environments like VS Code. fig-alt is also a no-op for ipynb output. Fix: embed the author's name in the markdown image alt text — [](url) The image caption is not an attribute and survives the stripping; a link wrapping only an image takes its alt as the accessible name across all markdown renderers. - Adds ipynb ORCID a11y regression test - Adds HTML/Reveal.js ORCID a11y regression tests, shares ORCID fixture across all three output paths Related to #14602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aria-label (and
alt=""for decorative image) to announce ORCID profile in author metadata HTML/Reveal.js to improve accessibility.This was detected when working with https://github.com/mcanouil/quarto-revealjs-a11y which has a feature to flag images with missing alt-text.
TO-DO: check upstream for similar fix.title-fancyseems to be pure Quarto eventhough underpandocdirectory.