Repository navigation
Use cl-quil's tools for safe resolution of included files - #224
Merged
Merged
Conversation
appleby
reviewed
Dec 18, 2019
appleby
left a comment
appleby
left a comment
Contributor
There was a problem hiding this comment.
Won't this require a cl-quil dependency bump?
Comment on lines
+70
to
+73
| (let ((val (loop :for (from to) :in graph | ||
| :sum (logxor (ldb (byte 1 from) cut) | ||
| (ldb (byte 1 to) cut))))) | ||
| val)) |
Contributor
Ah. Looking at test failures, it would appear so. |
jmbr
approved these changes
Dec 18, 2019
jmbr
left a comment
jmbr
left a comment
Member
There was a problem hiding this comment.
Nothing egregiously wrong jumps at me.
| (loop :for (from to) :in graph | ||
| :sum (logxor (ldb (byte 1 from) cut) | ||
| (ldb (byte 1 to) cut)))) | ||
| (let ((val (loop :for (from to) :in graph |
Member
There was a problem hiding this comment.
I don't see the rationale for wrapping the accumulated value of the loop in a let form only to return it immediately.
Member
Author
There was a problem hiding this comment.
I should've paid more attention to what I was committing.
Member
Author
Dang. Yes. |
stylewarning
approved these changes
Dec 18, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for this late PR. This removes some code duplication by using directly cl-quil's functions for safe resolution of include files.