Skip to content

Implement QVM debugger. - #245

Merged
jmbr merged 1 commit into
masterfrom
feature/debugger
Mar 24, 2020
Merged

jmbr merged 1 commit into
masterfrom
feature/debugger

Conversation

@jmbr

@jmbr jmbr commented Mar 13, 2020

Copy link
Copy Markdown
Member

No description provided.

@jmbr
jmbr requested a review from a team as a code owner March 13, 2020 16:56
@jmbr jmbr self-assigned this Mar 13, 2020
@jmbr
jmbr requested review from appleby and notmgsk March 13, 2020 16:56
@notmgsk

notmgsk commented Mar 13, 2020 •

Copy link
Copy Markdown
Member

So cool! A little asciinema demo would be e x t r a cool.

@jmbr

jmbr commented Mar 13, 2020

Copy link
Copy Markdown
Member Author

Wow, thanks!

@appleby appleby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Can't wait to try it out.

I don't consider any of these blockers, just "comment"ing in case you want to address any of them

Comment thread app/src/debugger.lisp
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp
@jmbr

jmbr commented Mar 14, 2020

Copy link
Copy Markdown
Member Author

So cool! A little asciinema demo would be e x t r a cool.

There you go: https://asciinema.org/a/310051 !

@jmbr

jmbr commented Mar 14, 2020

Copy link
Copy Markdown
Member Author

This is awesome! Can't wait to try it out.

I don't consider any of these blockers, just "comment"ing in case you want to address any of them

This was really valuable feedback. Thank you.

@appleby appleby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty

Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/debugger.lisp
Comment thread app/src/debugger.lisp Outdated
Comment thread app/src/entry-point.lisp
@jmbr
jmbr force-pushed the feature/debugger branch from 477c33d to 3a6f054 Compare March 23, 2020 03:21
@jmbr
jmbr force-pushed the feature/debugger branch from 3a6f054 to fea3b2d Compare March 23, 2020 03:27
@braised-babbage

Copy link
Copy Markdown
Contributor

This is very cool.

Comment thread app/src/debugger.lisp
@jmbr
jmbr merged commit 2d45449 into master Mar 24, 2020
@stylewarning
stylewarning deleted the feature/debugger branch March 25, 2020 18:19
@appleby appleby mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants