Skip to content

Install qvm to system in Docker builds - #248

Merged
notmgsk merged 1 commit into
masterfrom
feature/install-qvm-in-docker
Mar 20, 2020
Merged

Install qvm to system in Docker builds#248
notmgsk merged 1 commit into
masterfrom
feature/install-qvm-in-docker

Conversation

@notmgsk

@notmgsk notmgsk commented Mar 19, 2020

Copy link
Copy Markdown
Member

No description provided.

@notmgsk
notmgsk requested a review from a team as a code owner March 19, 2020 23:48
appleby
appleby approved these changes Mar 20, 2020
View reviewed changes

@appleby appleby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

@notmgsk

notmgsk commented Mar 20, 2020

Copy link
Copy Markdown
Member Author

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

👀 nah 👀

@appleby

appleby commented Mar 20, 2020

Copy link
Copy Markdown
Contributor

Should the ENTRYPOINT also be changed to /bin/qvm since we're installing it?

👀 nah 👀

absolute madlad

@notmgsk
notmgsk merged commit 1ee19c0 into master Mar 20, 2020
@appleby appleby mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@appleby appleby appleby approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@notmgsk @appleby